Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for discussion. The idea here is to centralize all requests made by ragnar to use httr2 and add a callback allowing users to modify requests. This allows users to use a central cache that can be shared for both finding links and reading documents. It also allows users to modify requests such that they can be retried, have a timeout, etc.
Here's an example:
Then links can be read with:
Another idea, would be for
find_links
to returnhttr2_response
objects (eg being something very similar to what ragnar_perform_spider() would do r-lib/httr2#456. Andragnar_read
being able to readhttr2_response
objects additionally.