Fix limit problem in raw_scan and unbouned problem in batch_scan #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <[email protected]>
Signed-off-by: ekexium <[email protected]>
ekexium
changed the title
15 tasks
Signed-off-by: ekexium <[email protected]>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
raw_scanlimit the final results.end_key=Some(empty)is treated as upper unbouned. The problem is also found in other places Plan for releasing 0.1 version #171 .Remaining problem:
each_limitofraw_batch_scanis not what we expect. It works on each region of each range, but not each range. It's not convenient to fix this problem so I suggest we keep this request but mark it as experimental for users Update readme #170 .