Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faker: add Spanish translation #16105

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

faker: add Spanish translation #16105

wants to merge 3 commits into from

Conversation

kant
Copy link
Member

@kant kant commented Apr 3, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@kant kant requested review from tricantivu and ikks as code owners April 3, 2025 19:04
@github-actions github-actions bot added the new translation PRs translating a page(s) from English to other languages. label Apr 3, 2025
@sebastiaanspeck
Copy link
Member

Hello! I've noticed something unusual when checking this PR:

  • The page pages.es/common/faker.md is outdated, based on the command contents itself, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

Please fix

sebastiaanspeck
sebastiaanspeck requested changes Apr 5, 2025
View reviewed changes
pages.es/common/faker.md Outdated

- Genera datos falsos de un tipo específico:

`faker {{nombre|dirección|pasaporte_completo|tarjeta_de_crédito_completa|número_teléfono|email|empresa|fecha_hora|nombre_usuario|contraseña|trabajo|...}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work? I don't think so.. faker name seems a subcommand to me and faker nombre will fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@kant
Copy link
Member Author

kant commented Apr 5, 2025

@sebastiaanspeck done

@sebastiaanspeck
Copy link
Member

sebastiaanspeck commented Apr 6, 2025 •
edited
Loading

@sebastiaanspeck done

Unfortunate not... the tldr-bot is still arguing

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2025

Hello! I've noticed something unusual when checking this PR:

  • The page pages.es/common/faker.md is outdated, based on the command contents itself, compared to the English page.

Is this intended? If so, just ignore this comment. Otherwise, please double-check the commits.

@kant
Copy link
Member Author

kant commented Apr 6, 2025

@sebastiaanspeck done

@sebastiaanspeck
Copy link
Member

@sebastiaanspeck done

Unfortunate not... the tldr-bot is still arguing

@spageektti
Copy link
Member

LGTM after the remaining issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck requested changes

@spageektti spageektti spageektti approved these changes

@tricantivu tricantivu Awaiting requested review from tricantivu tricantivu is a code owner

@ikks ikks Awaiting requested review from ikks ikks is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new translation PRs translating a page(s) from English to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kant @sebastiaanspeck @tldr-bot @spageektti