-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update windows-sys
to 0.59.0
#1857
base: master
Are you sure you want to change the base?
build: update windows-sys
to 0.59.0
#1857
Conversation
d9500d9
to
f74b07f
Compare
There's a build failure.
|
f74b07f
to
b3d675c
Compare
Ah, that was an interesting feature combination that I had to use to reproduce locally. 😅 Glad CI caught it! |
Any progress here ? |
b3d675c
to
066d1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM.
src/net/tcp/stream.rs
Outdated
@@ -284,7 +284,7 @@ impl Read for TcpStream { | |||
} | |||
} | |||
|
|||
impl<'a> Read for &'a TcpStream { | |||
impl Read for &TcpStream { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we undo these unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was changed by the commit titled chore: run `cargo +1.85.0 clippy --workspace --all-features --all-targets --fix`
. At the time, that was the easiest way to make CI pass; I'll try reverting this change, since it seems many of the other clippy
fixes have been subsumed by mainline.
Co-Authored-By: Erich Gubler <[email protected]>
066d1cd
to
e9e5846
Compare
Another useless lint was added to Clippy... I've opened #1870 to fix it, will merge this after. No need to make any further changes. |
Carries on the effort from #1820, with some fixes that should make tests compile now.