Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update windows-sys to 0.59.0 #1857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErichDonGubler
Copy link

Carries on the effort from #1820, with some fixes that should make tests compile now.

@Darksonn
Copy link
Contributor

There's a build failure.

     Checking mio v1.0.3 (D:\a\mio\mio)
  error[E0425]: cannot find function `null_mut` in this scope
    --> src\sys\windows\afd.rs:69:13
     |
  69 |             null_mut(),
     |             ^^^^^^^^ not found in this scope
     |
  help: consider importing this function
     |
  1  + use std::ptr::null_mut;
     |

@ErichDonGubler
Copy link
Author

ErichDonGubler commented Jan 22, 2025

@Darksonn:

There's a build failure.

     Checking mio v1.0.3 (D:\a\mio\mio)
  error[E0425]: cannot find function `null_mut` in this scope
    --> src\sys\windows\afd.rs:69:13
     |
  69 |             null_mut(),
     |             ^^^^^^^^ not found in this scope
     |
  help: consider importing this function
     |
  1  + use std::ptr::null_mut;
     |

Ah, that was an interesting feature combination that I had to use to reproduce locally. 😅 Glad CI caught it!

@Snowiiii
Copy link
Contributor

Any progress here ?

@ErichDonGubler
Copy link
Author

@Snowiiii: None, until you'd asked, and I'd refreshed my memory on this PR. 😀

I've updated the contents of the PR and its conversations with my latest thinking. I think this is ready for a re-review from @Darksonn.

@Snowiiii
Copy link
Contributor

@Darksonn ?

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM.

@@ -284,7 +284,7 @@ impl Read for TcpStream {
}
}

impl<'a> Read for &'a TcpStream {
impl Read for &TcpStream {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we undo these unrelated changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed by the commit titled chore: run `cargo +1.85.0 clippy --workspace --all-features --all-targets --fix` . At the time, that was the easiest way to make CI pass; I'll try reverting this change, since it seems many of the other clippy fixes have been subsumed by mainline.

@Thomasdezeeuw
Copy link
Collaborator

Another useless lint was added to Clippy... I've opened #1870 to fix it, will merge this after. No need to make any further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants