chore: allow nightly build to fail #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <[email protected]>
LucioFranco
approved these changes
Jul 11, 2019
yaahc
approved these changes
Jul 11, 2019
|
CI is failing for this branch because of deprecations, which We should probably not deny all warnings, IMO --- we should probably only deny some warnings. In particular, I think denying deprecations is a mistake, because it means cargo can pick up point releases of upstream deps that will then break our builds. |
hawkw
added a commit
that referenced
this pull request
Jul 11, 2019
Recent CI builds have failed on nightly due to a compiler bug: #174 (comment) In general, nightly Rust is unstable, and it may often fail for reasons that are not our fault. We shouldn't block merging branches on nightly failures, when they are often spurious or unrelated to `tracing`. It is, however, still good to look at these builds when possible. This branch allows failures on `nightly` CI builds. This means that the readme-doctest build is also allowed to fail, which is a shame. It would be good to find a solution for testing readme examples that doesn't require `nightly` Rust. I have some ideas for this that I'll try to address in a subsequent branch. Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recent CI builds have failed on nightly due to a compiler bug:
#174 (comment)
In general, nightly Rust is unstable, and it may often fail for reasons
that are not our fault. We shouldn't block merging branches on nightly
failures, when they are often spurious or unrelated to
tracing. It is,however, still good to look at these builds when possible.
Solution
This branch allows failures on
nightlyCI builds.This means that the readme-doctest build is also allowed to fail, which
is a shame. It would be good to find a solution for testing readme
examples that doesn't require
nightlyRust. I have some ideas for thisthat I'll try to address in a subsequent branch.
Signed-off-by: Eliza Weisman [email protected]