Skip to content

disable pep-517 for develop install #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tox/venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,8 @@ def install_pkg(self, dir, action, name, is_develop=False):
target = [dir]
if is_develop:
target.insert(0, "-e")
target.insert(0, "--no-use-pep517")

self._install(target, extraopts=pip_flags, action=action)

def developpkg(self, setupdir, action):
Expand Down
21 changes: 21 additions & 0 deletions tests/unit/package/builder/test_package_builder_isolated.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@ def test_verbose_isolated_build(initproj, mock_venv, cmd):
assert "Writing example123-0.5{}setup.cfg".format(os.sep) in result.out, result.out


def test_isolated_build_develop(initproj, cmd):
initproj(
"example123-0.5",
filedefs={
"tox.ini": """
[tox]
isolated_build = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe +1 regression test with this set to false would be nice

[testenv]
usedevelop = true
""",
"pyproject.toml": """
[build-system]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about another test without build-system? And +1 with build system but no build-backend...

requires = ["setuptools >= 41.0.0"]
build-backend = 'setuptools.build_meta'
""",
},
)
result = cmd("--notest", "-e", "py")
result.assert_success()


def test_dist_exists_version_change(mock_venv, initproj, cmd):
base = initproj(
"package_toml-{}".format("0.1"),
Expand Down