Skip to content

Fix for Windows cmd #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for Windows cmd #10

wants to merge 1 commit into from

Conversation

thchr
Copy link

@thchr thchr commented May 12, 2020

I was trying out Remark.jl on Windows and noticed that their call to open, which uses DefaultApplication.jl, didn't work.

From a bit of searching, it seems the start cmd command needs a title text (https://superuser.com/a/1335757). I'm not really sure whether start is even required here. Anyway, changing this worked for me.
(On the other hand, I don't quite understand why it e.g. works fine with the .txt file from DefaultApplication.test() - which indeed it does.)

Thanks!

I was trying out Remark.jl on Windows and noticed that their call to `open`, which uses DefaultApplication.jl, didn't work.

From a bit of searching, it seems the `start` cmd command needs a title text (https://superuser.com/a/1335757). I'm not really sure whether `start` is even required here. Anyway, changing this worked for me. 
(On the other hand, I don't quite understand why e.g. it works fine with the .txt file from `DefaultApplication.test()` - which indeed it does.)

Thanks!
@fonsp
Copy link
Contributor

fonsp commented Sep 2, 2020

Even better would be:

run(`$(cmd) /c start "" /b $(filename)`; wait = wait)

For start:
/b to not open a new terminal
https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/start

@tpapp
Copy link
Owner

tpapp commented Sep 3, 2020

Is there an issue for Remark.jl?

@rafael-guerra-www
Copy link

rafael-guerra-www commented Sep 2, 2024

@tpapp, fyi, currently this package doesn't launch Excel to open *.xslx files in Windows.
However, these files can be opened with @fonsp command above:

run(`cmd /c start "" /b $(filename)`; wait=true)

@tpapp
Copy link
Owner

tpapp commented Sep 3, 2024

Apologies for not resolving this issue for years now. The only excuse I have is that I don't use Windows so I cannot test these things directly.

This PR would need to be rebased, but given the change is small I would recommend opening a new one against current master, preferably with @fonsp's solution if that is the one that works. I promise to review and merge that quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants