Add support for unnamed_attr resolving in linker #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlauko
reviewed
Apr 7, 2025
Comment on lines
326
to
333
| if (isAppendingLinkage(srcLinkage) && isAppendingLinkage(dstLinkage)) { | ||
| if (srcUnnamedAddr != dstUnnamedAddr) { | ||
| pair.src->emitError("Appending variables with different unnamed_addr " | ||
| "need to be linked: ") | ||
| << pair.dst->getLoc(); | ||
| return failure(); | ||
| } | ||
| } |
There was a problem hiding this comment.
In llvm-link it happens in lib/Lnker/IRMover.cpp:877. I added it to satisfy the imported test. Should I move it somewhere else?
There was a problem hiding this comment.
Yes, this is to verbose and disctracts from logic.
Add some helper lambda linkError with use here like
return linkError("Appending variables with different unnamed_addr need to be linked:");
There was a problem hiding this comment.
And ideally extract entire thing to separate check function, because there will be more conditions on src and dst here. E.g. result should look like:
if (isAppendingLinkage(srcLinkage) && isAppendingLinkage(dstLinkage)) {
if (failed(verifyAppendingLinkageCompatibility(src, dst)))
return failure();
}
xlauko
reviewed
Apr 7, 2025
Jezurko
force-pushed
the
robert/unnamedattr
branch
from
9f339c9 to
9a73cc3
Compare
Jezurko
force-pushed
the
robert/unnamedattr
branch
2 times, most recently
from
6c620f3 to
7021e7f
Compare
xlauko
approved these changes
Apr 18, 2025
Jezurko
force-pushed
the
robert/unnamedattr
branch
from
7021e7f to
935fce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.