Skip to content

Remove support for deletion vectors in Iceberg #25550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Apr 10, 2025

Description

This PR reverts #24882. This isn't a breaking change because #24882 isn't yet released.

The upcoming Iceberg 1.9.0 makes row-lineage and default-values required in their V3 spec.
Shipping deletion vector without supporting those features will be troublesome.

I think we should wait until the V3 spec has stabilized.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Apr 10, 2025
@github-actions github-actions bot added docs iceberg Iceberg connector labels Apr 10, 2025
@ebyhr ebyhr force-pushed the ebi/iceberg-revert-deletion-vector branch from c556a04 to e50ea78 Compare April 10, 2025 12:58
@ebyhr ebyhr marked this pull request as ready for review April 10, 2025 13:03
@ebyhr ebyhr marked this pull request as draft April 13, 2025 11:30
@ebyhr ebyhr marked this pull request as ready for review April 17, 2025 01:37
@ebyhr ebyhr requested review from wendigo and anusudarsan April 17, 2025 01:37
Upcoming Iceberg 1.9.0 makes row lineage required.

This reverts commit 2645d51.
@ebyhr ebyhr force-pushed the ebi/iceberg-revert-deletion-vector branch from e50ea78 to e5e2ae4 Compare April 17, 2025 06:52
@wendigo
Copy link
Contributor

wendigo commented Apr 17, 2025

@ebyhr :shipit:

@ebyhr ebyhr merged commit 5210b0e into trinodb:master Apr 17, 2025
97 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-revert-deletion-vector branch April 17, 2025 07:44
@github-actions github-actions bot added this to the 475 milestone Apr 17, 2025
@ebyhr ebyhr mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants