add more exception message when getIcebergView failed #25565
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Hi @ebyhr May I know how to test this change? |
| throw new TrinoException(ICEBERG_CATALOG_ERROR, "Failed to load view '%s'".formatted(viewName.getTableName()), e); | ||
| throw new TrinoException(ICEBERG_CATALOG_ERROR, | ||
| "Failed to load view '%s', the configuration 'iceberg.rest-catalog.view-endpoints-enabled' is '%s'".formatted(viewName.getTableName(), | ||
| restSessionCatalog.properties().getOrDefault("view-endpoints-supported", "false")), e); |
There was a problem hiding this comment.
| restSessionCatalog.properties().getOrDefault("view-endpoints-supported", "false")), e); | |
| restSessionCatalog.properties().getOrDefault("view-endpoints-supported", "false")), | |
| e); |
| @@ -712,7 +712,9 @@ private Optional<View> getIcebergView(ConnectorSession session, SchemaTableName | |||
| return Optional.empty(); | |||
| } | |||
| catch (RESTException e) { | |||
| throw new TrinoException(ICEBERG_CATALOG_ERROR, "Failed to load view '%s'".formatted(viewName.getTableName()), e); | |||
| throw new TrinoException(ICEBERG_CATALOG_ERROR, | |||
| "Failed to load view '%s', the configuration 'iceberg.rest-catalog.view-endpoints-enabled' is '%s'".formatted(viewName.getTableName(), | |||
There was a problem hiding this comment.
This change doesn't make sense to me. We should include the property name only when the error cause is related to the property.
Description
Add configuration
iceberg.rest-catalog.view-endpoints-enabledvalue in exception message when get iceberg view failed.Additional context and related issues
#25556
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.