chore: add tskit-c as a submodule #748
Conversation
|
This is likely failing due to symbolic links in tskit-c. The issue of those links is why I had to remove the submodule a while back. Further, if this is going to work, we need to pin the submodule to the precise commit as the tskit-c release that we were using before. The policy is that tskit-rust is only built against an actual tskit-c release and not to some "random" commit in that repo. |
|
I stand corrected -- the build seems stable. But you need to update the CI files to actually check out the submodule recursively. Also need to work out which commit to use in the submodule.... |
|
@Unic-X -- thanks for this. I want to think about it a bit more. I used to find it "natural" for tskit-c to be a submodule, but submodules have several drawbacks. For example, it is too easy to work on different branches of a project that are synced to different commits of the submodule and accidentally change the synced commit of a branch. |
|
Yup make sense, i'll pin to the latest release's commit and test if it works. And i guess adding submodule flag inside the CI files should fix submodule issues. # Whether to checkout submodules: `true` to checkout submodules or `recursive` to
# recursively checkout submodules.
#
# When the `ssh-key` input is not provided, SSH URLs beginning with
# `[email protected]:` are converted to HTTPS.
#
# Default: false
submodules: ''And for the last part, how about a new CI to check if it matches with the latest release commit of |
I don't know how to do this automatically. |
Solves : #182