Fix double-replace #105
Open
Fix double-replace #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I got a JS error in
d3.parcoords.jswhen I tried to load my CSV file into Design Explorer and traced it back to this. In one code path a key is "cleaned" by replacing just the first period with a space, while in another it happens twice. If one of your CSV columns contains two or more periods, this discrepancy will break the visualization.Alternatively, you might want to change the "replace" on line 1109 to a "replace all" (
.replace(/\./g, ' ')).Thanks for the great tool!