Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active scale effect to animate-img #40878

Merged
merged 4 commits into from
Apr 3, 2025

Conversation

MohamadSalman11
Copy link
Contributor

@MohamadSalman11 MohamadSalman11 commented Sep 29, 2024

Description

Previously, there was only a hover effect that scaled the images up slightly. I added a new effect using the :active pseudo-class, which scales the images back down when clicked.

Motivation & Context

The active effect clearly shows the image changing, making it more user-friendly and enjoyable to click.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@mdo
Copy link
Member

mdo commented Apr 3, 2025

Nice little touch, tweaked to be more subtle though.

@mdo mdo merged commit 253db02 into twbs:main Apr 3, 2025
12 of 13 checks passed
@github-project-automation github-project-automation bot moved this from Needs review to Done in v5.3.4 Apr 3, 2025
madbob pushed a commit to madbob/bootstrap that referenced this pull request Apr 6, 2025
* Add active scale effect to animate-img

* Update _masthead.scss

---------

Co-authored-by: Mark Otto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants