Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Better indicate include options in sass setup. #41143

Merged

Conversation

Kelketek
Copy link
Contributor

@Kelketek Kelketek commented Jan 7, 2025

Description

This change makes a light improvement to the docs on including additional modules in Sass.

Motivation & Context

I'm in the middle of an upgrade, and I just spent the last several hours trying to track down why my custom variables for forms weren't working only to realize that the list of includes on the Sass page was not intended to be comprehensive, but only examples of sass sheets one might want to import, and that one should go through the sass directory to find any components they may yet need.

The changes I'm proposing here would have saved me a few hours, so I imagine they'll help a few other folks, too :)

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

https://deploy-preview-41143--twbs-bootstrap.netlify.app/ (Pending CI)

@mdo
Copy link
Member

mdo commented Jan 12, 2025

That's fair, easy improvement here.

@Kelketek Kelketek force-pushed the fox/improve-sass-includes-instructions branch from c789588 to d558cd0 Compare January 13, 2025 22:32
@Kelketek Kelketek force-pushed the fox/improve-sass-includes-instructions branch from d558cd0 to 161385e Compare April 7, 2025 23:43
@julien-deramond julien-deramond self-requested a review April 8, 2025 17:26
@github-project-automation github-project-automation bot moved this to To do in v5.3.6 Apr 8, 2025
@julien-deramond julien-deramond moved this from To do to Ready to merge in v5.3.6 Apr 8, 2025
@julien-deramond julien-deramond merged commit c9ad24b into twbs:main Apr 8, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Ready to merge to Done in v5.3.6 Apr 8, 2025
@Kelketek Kelketek deleted the fox/improve-sass-includes-instructions branch April 8, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants