Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Remove some unnecessary Twitter references/examples #41174

Merged
merged 2 commits into from
Apr 3, 2025
Merged

[Docs] Remove some unnecessary Twitter references/examples #41174

merged 2 commits into from
Apr 3, 2025

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Jan 23, 2025 •
edited
Loading

Description

Remove some unnecessary Twitter references/examples

Motivation & Context

Unnecessarily dated, and not the best reputation in recent years.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@patrickhlauke patrickhlauke requested a review from mdo January 23, 2025 21:13
@patrickhlauke
Copy link
Member Author

I'd actually suggest going much further (removing links to @mdo, @fat, @getbootstrap), but for now this is a start

@patrickhlauke patrickhlauke requested a review from mdo January 24, 2025 23:54
@patrickhlauke patrickhlauke force-pushed the remove-unnecessary-twitter-references branch 3 times, most recently from 58eb364 to b32a5c8 Compare January 25, 2025 00:05
@julien-deramond
Copy link
Member

@mdo Would you like me to review and assist with finalizing/merging it?

@mdo mdo force-pushed the remove-unnecessary-twitter-references branch from 642207c to 70fc814 Compare April 3, 2025 05:39
@mdo mdo force-pushed the remove-unnecessary-twitter-references branch from 70fc814 to 05d1018 Compare April 3, 2025 05:53
@mdo mdo merged commit ed25368 into main Apr 3, 2025
14 checks passed
@mdo mdo deleted the remove-unnecessary-twitter-references branch April 3, 2025 06:03
@github-project-automation github-project-automation bot moved this from Review in progress to Done in v5.3.4 Apr 3, 2025
@patrickhlauke
Copy link
Member Author

thanks @mdo

madbob pushed a commit to madbob/bootstrap that referenced this pull request Apr 6, 2025
@patrickhlauke @madbob
[Docs] Remove some unnecessary Twitter references/examples (twbs#41174)
30dcdef 
* Remove some unnecessary Twitter references/examples

* Changes suggested by @mdo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
docs v5
Projects
v5.3.4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickhlauke @julien-deramond @mdo