-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Sass deprecations notice in docs #41283
Conversation
Thanks for this PR, @MaxLardenois! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some edits that I'll accept after posting this.
c7f6ecc
to
98ff8c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! I fixed the cspell error, aligned the new comments for consistency, and adjusted the step in the Parcel guide so that the file is added only when needed. For the other two guides, they’re easier to explain once the config is in place.
Once this PR is merged, I’ll:
- open a PR in twbs/examples to apply these changes
- update my "Drop Node Sass" PR to consider removing these changes from both the documentation and twbs/examples
Description
This PR will add a callout in the docs to explain and provide links to potential resolution regarding Sass depreciation. Also it modifies
Vite
,Parcel
andWebpack
configs to silence the deprecations warnings from Dart Sass.Motivation & Context
Many issues are opened regarding the Sass deprecation notices (see #40962) and users must search the web to pinpoint the problem and potential workarounds, adding a callout directly in the docs while the core team is working on
node Sass
exit would be helpful for users and would limit erroneous new issues opening about these deprecations.We have the same problems with our company's fork's users who must search the web for information about these issues but we figured it could be an improvement on Bootstrap docs directly.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
#40962