Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme CSS selector for navbar and dropdown #41320

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pinggi
Copy link

@pinggi pinggi commented Mar 24, 2025

Description

Adds [data-bs-theme="dark"] selector to navbar and dropdown-menu, so it's possible to set dark color mode for the components by setting data-bs-theme="dark" attribute to html element (or any parent element of those components).

Motivation & Context

The dark theme set on html element wasn't applied to navbars and dropdowns. See the #41310.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#41310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants