Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention npm install and npm run dist in CONTRIBUTING.md #41340

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 3, 2025

Much simpler approach than #41333. Fixes #41209.

@mdo mdo added the meta label Apr 3, 2025
@mdo mdo changed the title Update CONTRIBUTING.md Mention npm install and npm run dist in CONTRIBUTING.md Apr 3, 2025
@mdo mdo added this to v5.3.5 Apr 3, 2025
@github-project-automation github-project-automation bot moved this to To do in v5.3.5 Apr 3, 2025
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The modifications sound nice, I've just added a comment to avoid having dist and js/dist files in the PRs.

@julien-deramond julien-deramond removed this from v5.3.5 Apr 4, 2025
@mdo mdo force-pushed the contributing-npm-1 branch from d833201 to 3ce9cec Compare April 6, 2025 19:47
@julien-deramond julien-deramond self-requested a review April 7, 2025 17:40
@julien-deramond julien-deramond merged commit 33bb991 into main Apr 7, 2025
13 checks passed
@julien-deramond julien-deramond deleted the contributing-npm-1 branch April 7, 2025 17:44
@julien-deramond julien-deramond moved this to Done in v5.3.6 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add npm install step to contribution guide in pull request section
2 participants