perf: replace Object.entries/fromEntries with Object.keys for better performance #1639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@typicode 👋
Thank you for providing such a great library. I have created this pull request to give you suggestions to improve the performance of
json-sever
.We can improve performance by changing
Object.fromEntries + entries + map + filter
toObject.keys + forEach
.In my benchmark tests, I verified a performance improvement of about
4.3x
or more for the latter.We can also define the type for
query
a bit more clearly.benchmark
Test
The test code also all passes fine. 🤗