Add remaining currency symbols, deprecate franc #59
Conversation
Add all relevant rupee symbols. I used "taka" for the bangladeshi rupee sign, since that is the name of the currency. "rupee.indian" is placed at the top of the list to avoid breaking changes. It's also the most widely used.
As far as I can gather, these are all extant symbols in unicode for currencies that are actively in use. Exceptions: - The "colon", used in costa rica - The gujarati rupee sign, as it has been proposed deprecated
|
I purposely avoided adding symbol names for currencies no longer in active use. |
|
Thoughts on also adding U+00A4 ¤ CURRENCY SIGN as |
I did consider that, but it seems to be a legacy symbol. Is it actually used? |
|
What about putting currencies under a module so that you can import what you need? |
I don't think there are any plans to have more categories than general symbols and emojis. In any case I think that would be a discussion not really specific to this PR? Edit: Also see the discussion under @mkorje 's comment |
|
Reading the Unicode core spec, there's also the Som Sign U+20C0 ⃀, the official currency symbol of the Kyrgyz Republic. |
| lira ₺ | ||
| manat ₼ | ||
| naira ₦ | ||
| peso ₱ |
There was a problem hiding this comment.
The core spec has this to say:
Dollar and Peso. The dollar sign (U+0024) is used for many currencies in Latin America and elsewhere. In particular, this use includes current and discontinued Latin American peso currencies, such as the Mexican, Chilean, Colombian and Dominican pesos. However, the Philippine peso uses a different symbol found at U+20B1.
So maybe peso should point to $ and peso.philippine to U+20B1 ₱ PESO SIGN.
There was a problem hiding this comment.
It's the only peso (as far as I know) with its own symbol.
There's several other currencies using the dollar symbol that would then presumably also need to be added. I don't think this is a good idea.
The goal isn't to add every currency, but every currency symbol.
There was a problem hiding this comment.
There appears to be only one other currency (other than peso and dollar) that uses the dollar symbol: the Macanese pataca (https://en.wikipedia.org/wiki/Currency_symbol#List_of_currency_symbols_currently_in_use).
There was a problem hiding this comment.
There appears to be only one other currency (other than peso and dollar) that uses the dollar symbol: the Macanese pataca (https://en.wikipedia.org/wiki/Currency_symbol#List_of_currency_symbols_currently_in_use).
Ok fair enough, if we're talking currencies with truly different names, then there are only three.
The question is whether we really want to start adding multiple names for the same currency symbols?
There was a problem hiding this comment.
I don't think it's a terrible idea if we do start to add multiple names. Especially when this situation with dollar appears to be the only one (and the yen and yuan).
| taka ৳ | ||
| taman ߿ | ||
| tenge ₸ | ||
| tugrik ₮ | ||
| won ₩ | ||
| yen ¥ |
There was a problem hiding this comment.
Slightly unrelated to the rest of the PR, but yuan should probably be added as an alias for ¥.
Yen and Yuan. Like the dollar sign and the pound sign, U+00A5 YEN SIGN has been used as the currency sign for more than one currency. The double-crossbar glyph is the official form for both the yen currency of Japan (JPY) and for the yuan (renminbi) currency of China (CNY). This is the case, despite the fact that some glyph standards historically specified a single-crossbar form, notably the OCR-A standard ISO 1073-1:1976, which influenced the representative glyph in various character set standards from China. In the Unicode Standard, U+00A5 YEN SIGN is intended to be the character for the currency sign for both the yen and the yuan, independent of the details of glyphic presentation.
There was a problem hiding this comment.
See my comment on dollar vs peso
Okay, in this specific case I'm slightly more convinced. However, yen and yuan have the same etymology. It's essentially a spelling difference.
That being said, it would perhaps be less controversial to have both instead of endorsing one.
There was a problem hiding this comment.
We already two different spellings for the Hebrew letters, so it's not unprecedented.
Good spot. I must've looked at outdated lists. I'll add it. |
|
I added the Kyrgysz currency and changed the name of the Mongolian currency. However, I think @laurmaedje would have to make the decision of whether we should add the additional aliases "yuan" (to yen), "peso" (and rename "peso" to "peso.phillipine") and "pataca" (to dollar). |
Adds the following currency symbols:
Armenian Dram Sign - dram (Currency of Armenia)
Afghani Sign - afghani (Currency of Aghanistan)
Bengali Rupee Sign - taka (Currency of Bangladesh)
Tamil Rupee Sign - rupee.tamil (Alternative symbol for Indian rupee in the Tamil alphabet)
Thai Currency Symbol Baht - baht (Currency of Thailand)
Khmer Currency Symbol Riel - riel (Currency of Cambodia)
Colon Sign - colon.currency (Currency of Costa Rica)
Naira Sign - naira (Currency of Nigeria)
Rupee sign - rupee.general (Currency of Mauritius, Nepal, Pakistan, Seychelles, Sri Lanka)
New Sheqel Sign - shekel (Currency of Israel)
Dong Sign - dong (Currency of Vietnam)
Kip Sign - kip (Currency of Laos)
Tugrik sign - tugrik (Currency of Mongolia)
Guarani Sign - guarani (Currency of Paraguay)
Hryvnia Sign - hryvnia (Currency of Ukraine)
Tenge Sign - tenge (Currency of Kazakhstan)
Manat Sign - manat (Currency of Azerbaijan)
Lari Sign - lari (Currency of Georgia)
Wancho Ngun Sign - rupee.wancho (Alternative symbol for Indian rupee in the Wancho alphabet)
Nko Dorome Sign - dorome (Currency symbol in the N'ko alphabet)
Nko Taman Sign - taman (Currency symbol in the N'ko alphabet)
Deprecates the following symbol:
French Franc Sign - franc (Not only is the currency no longer in use, the symbol was only a proposal and never used)