-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add slash.circle
#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add slash.circle
#60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This is probably fine to add if you need it, but otherwise I would suggest waiting for a resolution to #34 before adding any more "symbols inside shapes". A (maybe exhaustive?) list of those symbols is provided in Section 3.4. of the symbol Proposals document. |
I can't imagine that adding the symbol would make any breakage resulting from #34 substantially worse to deal with, considering any document that makes use of Hadamard division is almost certain to make even more frequent use of the Hadamard product, which is also affected. Having to wait for #34 to be resolved to have a nice way to type the Hadamard division operator seems a bit silly to me. |
Yeah that's what I meant by "It's probably fine to add if you need it": let's not block adding one symbol on some hypothetical future change if there is an actual need for said symbol. 👍 |
You would have to wait for the next version of typst regardless, and its likely that #34 would be resolved by then |
Oh, if it'll have been dealt with before the next typst release anyway, I don't personally care either way. I just assumed that #34 might be a while since it's been open for a few months already with seemingly no/little discussion. |
Most of the discussion takes place on discord, and there's not a lot of incentive to move fast when there's no imminent release. |
We can probably keep this PR open and merge it before the next release if it becomes apparent that #34 will not be solved by then. |
This adds the name
slash.circle
for the Unicode symbol ⊘, which was inexplicably missing despite seemingly every other circled operator being included. This symbol is sometimes used for Hadamard (element-wise) division, and is available as\oslash
in LaTeX.