Skip to content

Rename angle.spheric.top to angle.spheric.t #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented May 19, 2025

The current name was inconsistent with our naming scheme.

There's also a broader discussion to be had whether all the .rev variants we have make sense. If there is a "canonical" direction, such as for in, then yes, but I have no idea what to expect for angle.spheric. It would better to use names like angle.spheric.r, angle.spheric.l and angle.spheric.t to indicate which way it opens.

I didn't make that change, but the same comment applies to angle.rev, angle.right.rev, and angle.arc.rev

@mkorje
Copy link
Collaborator

mkorje commented May 19, 2025

I agree that .r, .l and .t would be better modifier names for angle.spheric. You may as well make those changes in this PR then.

On the other hand, angle.right and angle.arc don't have (maybe there is a character just not with a name in codex yet) top or bottom variants, so I don't think .rev is that bad.

@Enivex
Copy link
Collaborator Author

Enivex commented May 19, 2025

On the other hand, angle.right and angle.arc don't have (maybe there is a character just not with a name in codex yet) top or bottom variants, so I don't think .rev is that bad.

It's not as bad, but the problem of not knowing which is which persists. If I show you a symbol, would you be able to tell me if it's angle.right or angle.right.rev?

I can't speak to whether there are missing variants, as I've not investigated that.

@MDLC01
Copy link
Collaborator

MDLC01 commented May 19, 2025

If I show you a symbol, would you be able to tell me if it's angle.right or angle.right.rev?

My intuition agrees with what we currently have. Same for the other default (i.e., not .rev or .inv) angle variants.

I agree that .rev and .inv here are not great, but at the same time, I don't feel like .t, .l, .b, and .r are better. In fact, given the default direction feels natural to me, I find the former better. Also, this would just move the problem: in angle.t, should the angle itself be pointing top? Should the direction the angle is measured from be pointing top? It's equally ambiguous: you have to decide what the reference is: what is pointing in the direction. The same way right now you have to know which is he default orientation (which feels natural to me).

@Enivex
Copy link
Collaborator Author

Enivex commented May 19, 2025

Well, I'd consider the natural direction to be wherever the interior angle is. It's not like it's an arrow.

@Enivex
Copy link
Collaborator Author

Enivex commented May 19, 2025

I should also point out that the current name is not inv, but top. It's literally the only symbol where we're using the full word top instead of t.

@MDLC01
Copy link
Collaborator

MDLC01 commented May 19, 2025

I agree that .top should change. I was arguing about the other ones.

@MDLC01 MDLC01 added the breaking This involves a breaking change label May 20, 2025
@MDLC01 MDLC01 requested a review from laurmaedje May 20, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This involves a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants