Skip to content

Add playing cards #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add playing cards #74

wants to merge 3 commits into from

Conversation

Enivex
Copy link
Collaborator

@Enivex Enivex commented May 22, 2025

  • One possibility is moving the suit symbols into this, but that would be a breaking change.
  • I considered using roman numerals for the the numbering of the trump cards. However, we've just spelled out numbers elsewhere, so I did that for consistency.
  • Each tarot card also has a meaning (https://en.wikipedia.org/wiki/Bourgeois_Tarot#Tarot_Nouveau) which could possibly be an alias, but I'm not sure if it's worth it.

@Enivex
Copy link
Collaborator Author

Enivex commented May 22, 2025

Hm, it's failing because of the text variation selector on card.joker.black.

Should I

  • Remove the variation selector
  • Remove the black joker for the time being
  • Wait until variation selectors are supported

?

@Enivex
Copy link
Collaborator Author

Enivex commented May 22, 2025

Also: Is card too generic? I couldn't think of another option not involving having to use a hyphen (which we've avoided so far)

@T0mstone
Copy link
Collaborator

Should I

  • Remove the variation selector

  • Remove the black joker for the time being

  • Wait until variation selectors are supported

I'd advocate for waiting on #25

@Enivex Enivex added the multi-character symbols This requires multi-code point symbols label May 22, 2025
@T0mstone
Copy link
Collaborator

Also: Is card too generic? I couldn't think of another option not involving having to use a hyphen (which we've avoided so far)

For the record, I think playingcard without any separator would be fine too.

@Enivex
Copy link
Collaborator Author

Enivex commented May 24, 2025

It's a bit long, but presumably anyone using this would import the submodule anyway.

@Enivex Enivex changed the title Add playing cards submodule Add playing cards May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-character symbols This requires multi-code point symbols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants