-
Notifications
You must be signed in to change notification settings - Fork 6
Intergrate conf snippets in include_sections
from migrid PR244.
#105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intergrate conf snippets in include_sections
from migrid PR244.
#105
Conversation
…erver.conf `include_sections` support. Copies any files in the `external-conf-sections` folder into the resulting container `/home/mig/mig/server/MiGserver.d/` folder where they will be included by default.
include_sections
from migrid PR244.include_sections
from migrid PR244.
Tested to work in practical deployment, so mainly left as a decision if this is indeed the way we want to support configuration snippets or if a bind mounted volume with snippets is better, as we briefly discussed off-list. Rebuilding is of course tedious but updates are supposedly rare and typically will require at least service restarts, anyway. |
I foresee that we will be generating the configuration snippets as a part of the build process such as the global conf ? That is, I don't think neither the volume bind nor the cert-like copy will suit us? |
We will not be generating e.g. the cloud conf as pulling that out of the generator loop was the main motivation for introducing conf snippet support. |
Fine with pulling the non-core functionality out of generateconfs but I think that eg. the CLOUD confs should be build/generated as a part of the image like the rest of our external dependencies. |
Well, the COPY method implemented here will insert any available conf snippets including CLOUD into the image during build. |
Then I would prefer MiGserver.d as a bind mounted volume. |
...
Alright, thanks for the input both of you (partially off-list). I'll take a look at a bind mount solution. |
…s like PR105 using bind mount (#106) An alternative integration of the mig server config extension snippets like PR #105 but using a bind mounted volume in `PERSISTENT_ROOT` for the config snippets instead as agreed in the PR discussion. This will enable easy adjustment of e.g. the `CLOUD_X` sections where user access and such may need more frequent updates than what is feasible to handle with rebuild/redeploy every time.
Obsoleted by PR #106 . |
Reuse the strategy from external-certificates folder for the new MiGserver.conf
include_sections
support. Copies any files in theexternal-conf-sections
folder into the resulting container/home/mig/mig/server/MiGserver.d/
folder where they will be included by default.