Add logging for Movement events #4147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crStiv is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
|
thanks for the pr! please use |
|
@benluelo made changes as you asked and solved some ci errors |
benluelo
reviewed
Apr 5, 2025
There was a problem hiding this comment.
just a few small comments. additionally, please refer to our CONTRIBUTING.md (we use conventional commits).
|
@benluelo made changes, btw you want me to change all the commit names or just the last one that I've changed already? |
|
yes, you will either need to squash or rename all of your commits (i recommend just squashing) |
Update main.rs Update main.rs Update main.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some useful logging for Movement IBC events so we can better track what's happening. Includes basic info like event type, block height, and tx hash, plus the key fields for each event type.
Fixes #3953.