Skip Github flow on local for easier testing of user creation flows #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When running in the local deployment, going through the "login" flow will short-circuit going to github and will instead complete the auth flow using dummy github user info, which helps make testing the user creation flow a lot easier.
Implementation notes
The only difference is that it skips redirecting through Github, and doesn't call the github APIs to get the user data and instead uses constant dummy user info.
Test coverage
I added a new user creation transcript to ensure we don't break the user creation flow.
Loose Ends
@hojberg you could optionally wire up the "Login", "Register" and "Logout" buttons in the local UI if you like :)