fix(LoggerExtensions): Add typed LogMessage functions #2723
+576
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding this Description of the actual returned Value of this, its enabling the user to actually know, that its an override he can use to get the Route easily as interpolated string.
… Issue 2708 and added xml documentation to each LoggerExtensions function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #2708
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If untyped ILogger is wanted by Model HostBuilder is failing to resolve it.
What is the new behavior?
Since its just happening if I used this functions untyped that should hopefully fix it. Did not find the depending HostBuilder Extensions which could also have a Problem causing this
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Added also some xml documentation, but since docfx.json does not make use of src, there would not be a real point of adding those by hand to md docs right now
Internal Issue (If applicable):