feat: Added tracing instrumentation into Hot Reload #19754
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces tracing instrumentation into the hot reload workflow, enabling ETW-based event logging to aid performance analysis with PerfView.
- Integrated tracing events into the hot reload and update file workflows in the VS remote control entry point.
- Added tracing calls in the hot reload processor to log reload events.
- Implemented a new EventTracingProvider for ETW event logging.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Uno.UI.RemoteControl.VS/EntryPoint.cs | Added tracing calls around force hot reload and file update operations. |
| src/Uno.UI.RemoteControl.Server.Processors/HotReload/ServerHotReloadProcessor.cs | Inserted a tracing event for hot reload events to log event source and type. |
| src/Uno.UI.RemoteControl.Messaging/EventTracingProvider.cs | Introduced a new ETW tracing provider for logging hot reload events. |
Files not reviewed (1)
- src/Uno.UI.RemoteControl.Server.Processors/Uno.UI.RemoteControl.Server.Processors.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/Uno.UI.RemoteControl.VS/EntryPoint.cs:545
- [nitpick] The variable name 'success' is generic. Consider renaming it to 'hotReloadSucceeded' to improve clarity.
var success = false;
src/Uno.UI.RemoteControl.VS/EntryPoint.cs:581
- [nitpick] The variable name 'success' is generic. Consider renaming it to 'updateFileSucceeded' to clearly indicate its purpose in the file update workflow.
var success = false;
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19754/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19754/index.html |
|
The build 158876 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
This PR introduces tracing instrumentation into the hot reload workflow, enabling ETW-based event logging to aid performance analysis with PerfView.
Uno.HotReload.TracingProviderNote
DRAFT: Still improving it and needs some docs.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):