[BREAKING CHANGES] New base setup #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: package-lock.json modified: package.json modified: src/main.ts
mob8607
force-pushed
the
feature/new-base-setup
branch
from
0c9b29a to
e3d89f0
Compare
mob8607
reviewed
Apr 30, 2025
.github/workflows/test.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: ['feature/new-base-setup'] |
There was a problem hiding this comment.
Question: Can we update this so it works on all future branches?
There was a problem hiding this comment.
yes, we need to check if we can use wildcards
| id: 'theme-02', | ||
| selected: false, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Question This is just as an example right? Because we now only have one default theme in our template.
There was a problem hiding this comment.
ah yes, we could remove it I guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This merge request extracts the styleguide and the base scss setup in new reusable repositories. The vue-template will be a boilerplate how to setup a project with all dev-tools outsourced and versioned in the future.
Ticket
ticket-link
Browser testing
Checklist
Review/Test checklist