Modify smoothStream transform to support tool call streams #5326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the smoothStream transform to handle both text and tool call streaming: - Add separate buffers for text and tool call arguments - Special handling for tool-related chunk types (tool-call, tool-call-delta, tool-result) - Add buffer flushing logic for various stream states - Implement TransformStream flush method to handle remaining content - Keep consistent chunking behavior across both text and tool call streams
|
Please run pnpm |
|
There are some bugs. Can you add test cases as a first step? Once this is bug-free there will also need to be some refactoring. Finally, this feature should be opt in using a flag e.g. |
lgrammel
reviewed
Mar 26, 2025
Comment on lines
+147
to
154
| if (toolCallBuffer && toolCallBuffer.buffer.length > 0) { | ||
| controller.enqueue({ | ||
| type: 'tool-call-delta', | ||
| toolCallId: toolCallBuffer.id, | ||
| toolName: toolCallBuffer.name, | ||
| argsTextDelta: toolCallBuffer.buffer, | ||
| }); | ||
| } |
There was a problem hiding this comment.
bug: what if there are several ongoing tool calls?
lgrammel
reviewed
Mar 26, 2025
Comment on lines
+73
to
+79
| controller.enqueue({ | ||
| type: 'tool-call-delta', | ||
| toolCallId: toolCallBuffer.id, | ||
| toolName: toolCallBuffer.name, | ||
| argsTextDelta: toolCallBuffer.buffer, | ||
| }); | ||
| toolCallBuffer = null; |
There was a problem hiding this comment.
bug: what if there are several ongoing tool calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the smoothStream transform to handle both text and tool call streaming: