feat: typescript project references #5518
Merged
+2,158
−506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdenty
force-pushed
the
samd/project-references
branch
from
def741d to
54f6337
Compare
lgrammel
requested changes
Apr 3, 2025
samdenty
force-pushed
the
samd/project-references
branch
from
6263872 to
7433096
Compare
samdenty
force-pushed
the
samd/project-references
branch
from
7605205 to
91e0a50
Compare
samdenty
force-pushed
the
samd/project-references
branch
from
9fc37a7 to
0fce2b9
Compare
samdenty
commented
Apr 9, 2025
|
|
||
| describe('StreamableValue type', () => { | ||
| it('should not contain types marked with @internal after compilation', () => { |
There was a problem hiding this comment.
this is now not possible to do since we don't have separate dist builds, and it would result in a compile error otherwise
samdenty
commented
Apr 9, 2025
| @@ -77,4 +77,4 @@ jobs: | |||
| run: pnpm install --frozen-lockfile | |||
|
|
|||
| - name: Run TypeScript type check | |||
| run: pnpm run type-check | |||
| run: pnpm run type-check:full | |||
There was a problem hiding this comment.
full does it with examples, normal tsconfig does without so it's faster
lgrammel
reviewed
Apr 9, 2025
| @@ -42,11 +42,12 @@ | |||
| "scripts": { | |||
| "test:e2e:all": "vitest run src/e2e/*.test.ts", | |||
| "test:file": "vitest run", | |||
| "type-check": "tsc --noEmit" | |||
| "type-check": "tsc --build" | |||
There was a problem hiding this comment.
where will the js files go?
There was a problem hiding this comment.
i've added a clean step before running the actual build, so this ensures that before publishes we always have only the correct stuff. Due to microsoft/TypeScript#40431, typescript doesn't yet support noEmit with references. What I could do is instead have a separate dist folder?
with this change you'll have to run build after type-check
lgrammel
reviewed
Apr 9, 2025
lgrammel
reviewed
Apr 9, 2025
samdenty
force-pushed
the
samd/project-references
branch
from
6050e32 to
1b69fb9
Compare
lgrammel
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds project references to the AI SDK codebase.
Improvements
Possibly breaking changes
Typescript requires the source folders to match output folders, so we would require a bunch of difference tsconfigs with circular dependencies which aren't supported.
So this PR changes the packages with multiple dist folders to instead from:
to
This could be a breaking change if people are depending on the filepath in the package. But if they're importing the package directly, it'll use the import map that i've updated to now use the new format (so should continue working)