fix ({}).constructor===Object #1047
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Schniz
commented
Dec 4, 2024
| @@ -12,7 +12,7 @@ test('Error maintains a stack trace', async () => { | |||
| vm.evaluate(`(${fn})()`) | |||
|
|
|||
| expect(log).toHaveBeenCalledTimes(1) | |||
| expect(log.mock.lastCall[0]).toMatch(/^Error: hello, world!\s+at fn/m) | |||
| expect(log.mock.lastCall[0]).toMatch(/^Error: hello, world!\s+at Object/m) | |||
There was a problem hiding this comment.
this is my main concern 👀
this resolves #899 with a caveat that an object that was created outside of the VM will obviously won't satisfy this requirement. However, it will still be `instaceof Object` which is interesting. I am not sure it'll be easy to solve.
Kikobeats
force-pushed
the
schniz/fix-dot-constructor
branch
from
aba27c0 to
819fabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this resolves #899 with a caveat that an object that was created outside
of the VM will obviously won't satisfy this requirement. However, it will
still be
instaceof Objectwhich is interesting. I am not sure it'll be easy to solve.