Migrate to dynamicIO
#198
Merged
Migrate to dynamicIO
#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![Screenshot of /error/[section]/[category]](https://images.weserv.nl?url=https://sjc.microlink.io/ZLRGy_maL04hgrmaZGtZk3ogn30BW-TqjzBg6IhIFP4EmKgkCtIW4jdMxRLV2QdSXJbUKJ0e_06Cj1MrutAvWw.png&w=600)
![Screenshot of /error/[section]](https://images.weserv.nl?url=https://sjc.microlink.io/4vRQXKg0Y2YLD0Chk1ecohvqXUtzIzXhTAQixZH6RZxHUNeTjzOKyUVf1A3jVSvhNlarPimD-E6x5qLOwKAOmQ.png&w=600)
![Screenshot of /layouts/[section]/[category]](https://images.weserv.nl?url=https://sjc.microlink.io/J32mj4toEr2em2lRC5yHhrHTOzlmoQ5YsRm7rayPFsXlnBif9PerTvE2mUvcoPdK32tm8lIkpwA2_AoHs9M1fw.png&w=600)
![Screenshot of /layouts/[section]](https://images.weserv.nl?url=https://sjc.microlink.io/cjHcyUFdjdNyTZ9lgTQPzEsxJxYcsfi0xf07BpezjpC6rPZnSOFIFwRUZp3vInRNTOW0MRRO8ppM5q9aL-75Eg.png&w=600)
![Screenshot of /not-found/[section]/[category]](https://images.weserv.nl?url=https://sjc.microlink.io/2d3COfwRTPJfQwXcf0dKq47cGcBwPbiR-i_OU-i_u3AqWJWaw4ivYoowc6SL0_8pgqMeM00uZuqDiDGBphhGIA.png&w=600)
![Screenshot of /not-found/[section]](https://images.weserv.nl?url=https://sjc.microlink.io/g86YAB51_T6dfdTsTq_7QiRXDbecpgTlJdbO8B-e6kkttzAWXpFx5wH48WKCw2aYhNv1poN9b4-AVldooRcamA.png&w=600)
For the `useLinkStatus` example, I had to add a loading boundary, which is required by Dynamic IO for a fully dynamic page. This means that the inline loading indicator is only shown when starting on the home page, and then navigating to the `useLinkStatus` page and its child pages. When starting at `/use-link-status`, the loading boundary is available to the client router, and will be used instead of the inline indicator when switching between child pages.
unstubbable
commented
May 28, 2025
| fallback={<NavItem item={item} close={close} />} | ||
| > | ||
| <DynamicNavItem item={item} close={close} /> | ||
| </Suspense> |
There was a problem hiding this comment.
The goal here is to put the suspense boundary as deep in the tree as possible, so that the fallback shell for routes with dynamic params can include these elements. Since NavItem was using useSelectedLayoutSegment which suspends on accessing the fallback params, we split it into a dynamic component and a skeleton component. Same for TabContent.
delbaoliveira
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
useLinkStatusexample I had to add a loading boundary, which is required by Dynamic IO for a fully dynamic page. This means that the inline loading indicator is only shown when starting on the home page, and then navigating to theuseLinkStatuspage and its child pages. When starting at/use-link-status, the loading boundary is available to the client router, and will be used instead of the inline indicator when switching between child pages.