[Turbopack] name the module factory function in dev mode #73553

sokra · 2024-12-05T15:37:14Z

What?

In development give the module factory a useful name, so it's clear in stack traces that this is the module evaluation part of the execution.

This also fixes some bugs with the stack trace parser, which seems to struggle if function names contain brackets. The automatically inferred function name would be the module id, which contains brackets.

sokra · 2024-12-05T15:37:34Z

Turbopack: hide useless method names #73586
[Turbopack] name the module factory function in dev mode #73553 👈 (View in Graphite)
[Turbopack] fix import.meta.url in monorepo #72612
[Turbopack] fix root and project path usages in a monorepo #73552 : 2 other dependent PRs (#73584 , #73585 )
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2024-12-05T15:45:24Z

Failing test suites

Commit: e4c1a88

pnpm test test/integration/server-side-dev-errors/test/index.test.js

server-side dev errors > should show server-side error for api route correctly
server-side dev errors > should show server-side error for dynamic api route correctly

Expand output

● server-side dev errors › should show server-side error for api route correctly

page.$$: Execution context was destroyed, most likely because of a navigation

  417 |   elementsByCss(sel) {
  418 |     return this.chain(() =>
> 419 |       page.$$(sel).then((els) => {
      |            ^
  420 |         return els.map((el) => {
  421 |           const origGetAttribute = el.getAttribute.bind(el)
  422 |           el.getAttribute = (name) => {

  at $$ (lib/browsers/playwright.ts:419:12)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as elementsByCss] (lib/browsers/playwright.ts:418:17)
  at elementsByCss (lib/next-test-utils.ts:1379:53)
  at createErrorSnapshot (lib/add-redbox-matchers.ts:85:30)
  at createErrorSnapshot (lib/add-redbox-matchers.ts:174:33)
  at Object.toDisplayRedbox (lib/add-redbox-matchers.ts:238:20)
  at Object.<anonymous> (integration/server-side-dev-errors/test/index.test.js:237:7)

● server-side dev errors › should show server-side error for dynamic api route correctly

page.$$: Execution context was destroyed, most likely because of a navigation

  417 |   elementsByCss(sel) {
  418 |     return this.chain(() =>
> 419 |       page.$$(sel).then((els) => {
      |            ^
  420 |         return els.map((el) => {
  421 |           const origGetAttribute = el.getAttribute.bind(el)
  422 |           el.getAttribute = (name) => {

  at $$ (lib/browsers/playwright.ts:419:12)
  at BrowserInterface.chain (lib/browsers/base.ts:17:23)
  at BrowserInterface.chain [as elementsByCss] (lib/browsers/playwright.ts:418:17)
  at elementsByCss (lib/next-test-utils.ts:1379:53)
  at createErrorSnapshot (lib/add-redbox-matchers.ts:85:30)
  at createErrorSnapshot (lib/add-redbox-matchers.ts:174:33)
  at Object.toDisplayRedbox (lib/add-redbox-matchers.ts:238:20)
  at Object.<anonymous> (integration/server-side-dev-errors/test/index.test.js:297:7)