Skip to content

[release] couple next and @next/swc versions #79036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

[release] couple next and @next/swc versions #79036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .changeset/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
"changelog": "@changesets/cli/changelog",
"commit": false,
"fixed": [],
"fixed": [["next", "@next/swc"]],
"linked": [],
"access": "public",
"baseBranch": "canary",
Expand Down
4 changes: 1 addition & 3 deletions scripts/publish-native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ const cwd = process.cwd()
try {
const publishSema = new Sema(2)

let version = JSON.parse(
await readFile(path.join(cwd, 'lerna.json'))
).version
let version = require('@next/swc/package.json').version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this is already updated by the time this script runs (e.g. via doing a dry run of our current release process)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good catch. No, not in the new release. Actually, there are several tasks that need to be ported from the publishRelease task. Will update them at #79037 and move this PR after that stack.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now ensured that the versioning will always run ahead of this script by #79037.


// Copy binaries to package folders, update version, and publish
let nativePackagesDir = path.join(cwd, 'crates/napi/npm')
Expand Down
Loading