Skip to content

docs: clarify unmounting modals with parallel routes #79534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

adriandlam
Copy link

Clarify that adding a page.tsx or [...catchAll]/page.tsx returning null in the slot is needed for modals to unmount on client-side navigation.

See related discussion: Modals not dismissing on forward routing #50284

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label May 23, 2025
Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: 797de77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ijjk
Copy link
Member

ijjk commented May 23, 2025

Allow CI Workflow Run

  • approve CI run for commit: 214f3c6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented May 23, 2025

Allow CI Workflow Run

  • approve CI run for commit: 797de77

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@adriandlam adriandlam marked this pull request as ready for review May 23, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants