Improve comments in Makefile #3097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmirhosseinPoolad
force-pushed
the
make_default_debug_info
branch
2 times, most recently
from
9c38f6f to
e78edfe
Compare
AmirhosseinPoolad
changed the title
There was a problem hiding this comment.
Hi @AmirhosseinPoolad , thanks for this update! Some comments below.
AmirhosseinPoolad
force-pushed
the
make_default_debug_info
branch
3 times, most recently
from
a643aee to
6670fb7
Compare
AmirhosseinPoolad
force-pushed
the
make_default_debug_info
branch
from
6670fb7 to
b72cb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR better documents the possible options users have when using the makefile.