DATA-3781: Deprecate AddTagsToBinaryDataByFilter, RemoveTagsFromBinaryDataByFilter #661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpandiarajan20
added
ready-for-protos
vijayvuyyuru
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
These changes look fine to me. Not sure what the timeline is on fully removing these. Theres a reasonable chance youll need to update RDK and app to have no lints around these methods on the newest API version, otherwise itll block other peoples merges. Im not as sure about the SDKs outside of Go. Also not sure if this needs to be posted in breaking changes, I assume these endpoints arent really used?
tahiyasalam
reviewed
Apr 2, 2025
tahiyasalam
requested changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marks Add/RemoveTagsToBinaryDataByFilter as deprecated. I'm actually not sure if I should be doing anything else to deprecate these endpoints, so please let me know!