Skip to content

DOCS-4069: Clarify module upload version restrictions for same architecture #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

promptless[bot]
Copy link
Contributor

@promptless promptless bot commented Jun 6, 2025

Based on user feedback, add clarification to the CLI documentation that you cannot upload two files for the same architecture with the same version number. This addresses a common confusion point where users might try to upload multiple files with identical version numbers and architectures, which is not allowed by the system.

Trigger Events


If you want Promptless to make further changes on this PR, feel free to leave a comment tagging Promptless (It won't show up in the user drop down but Promptless will get it!)

Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 723f197
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6843378a516f0d00082a3a29
😎 Deploy Preview https://deploy-preview-4384--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 49 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JessamyT
❌ promptless[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor Author

promptless bot commented Jun 6, 2025

Just a reminder: If you'd like me to act on any feedback you have via Github comments, just type @Promptless in your suggestion and I'll get right on it! (I won't show up in the user dropdown, but I'll process any request that has @Promptless in the comment body.)

@viambot
Copy link
Member

viambot commented Jun 6, 2025

👋 Thanks for contributing! A reviewer will look at it on the next working day!

@JessamyT JessamyT changed the title docs: Clarify module upload version restrictions for same architecture DOCS-4069: Clarify module upload version restrictions for same architecture Jun 6, 2025
Copy link
Member

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I suggestion-scope-creep-nerd-sniped myself :(

Comment on lines 1001 to 1002
You cannot upload two files for the same architecture with the same version number.
You must increment to a new version number, even if you delete a previous version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[s] rephrase from negative 'cannot' to positive 'can'. switch from technically-incorrect 'two' term (technically, you cannot upload more than one, but that's wordy as hell).

Suggested change
You cannot upload two files for the same architecture with the same version number.
You must increment to a new version number, even if you delete a previous version.
Each architecture distribution for a given version of a module is immutable.
You can delete the version, but you can never change an uploaded architecture distribution.
To update your module, increment to a new version number.

Sidenote: right now we overload the term 'version' to refer to both:

  • numbered releases of a module
  • the artifacts uploaded for each architecture

Most package managers, etc would refer to the per-architecture artifacts as distributions. I suggest we do the same here, and potentially above (change 'version' in the following sentence to 'distribution'):

For example, if you upload your module with support for `any/amd64` and then also upload with support for `linux/amd64`, a machine running the `linux/amd64` architecture deploys the `linux/amd64` version, while a machine running the `darwin/amd64` architecture deploys the `any/amd64` version.

It would probably be worthwhile to do the same on the rest of this page, and potentially add the term 'distribution' to the glossary or at least define it on this page as well. Otherwise we'll be stuck mucking about with ambiguity every time we want to refer to this concept! If that's too much scope creep, feel free to create a ticket and assign me -- I have a pretty good notion of how to handle it.

Copy link
Member

@nathan-contino nathan-contino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JessamyT JessamyT merged commit c93d51f into main Jun 6, 2025
12 of 13 checks passed
@JessamyT JessamyT deleted the docs-update-a4656b99-5edc-44c1-aef0-15dfcd843b0e-20250606-001736 branch June 6, 2025 22:30
Copy link

github-actions bot commented Jun 6, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants