isolate nlopt dependency further by moving inject.motion_service.go to its own package
#4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
raybjork
commented
Apr 10, 2025
| @@ -6,7 +6,7 @@ import ( | |||
| "strconv" | |||
|
|
|||
| "github.com/golang/geo/r3" | |||
| protov1 "github.com/golang/protobuf/proto" //nolint:staticcheck | |||
| protov1 "github.com/golang/protobuf/proto" | |||
There was a problem hiding this comment.
I think this was added by the linter
raybjork
commented
Apr 10, 2025
| @@ -462,13 +461,6 @@ func TestManagerAdd(t *testing.T) { | |||
| test.That(t, err, test.ShouldBeNil) | |||
| test.That(t, resource1, test.ShouldEqual, injectBoard) | |||
|
|
|||
| injectMotionService := &inject.MotionService{} | |||
There was a problem hiding this comment.
This part of the test does not seem to add anything and means that anyone importing resource also needs to import nlopt by transitive dependencies (although the reason resource is importing this is unclear to me)
viambot
added
safe to test
JohnN193
approved these changes
Apr 10, 2025
actually quickish q, nlopt is no longer in the go.mod but it still appears in the go.sum for my modules. Would that still cause build issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when someone tries to import anything in the
injectpackage (for example if they are writing unit tests for their module) they are forced to import nlopt too. This PR creates a separate package for injected motion so that this only is required when someone goes to importinject/motionrather than justinject.This is the cleanest solution I thought of but looking for sign off from @cheukt since it is a departure from how we have structured RDK so far.