RC version bump #409
Merged
RC version bump #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lia-viam
requested review from
njooma and
stuqdog
and removed request for
a team
|
@lia-viam - Looks like something doesn't like that release tag format. |
|
Let's not move forward with this since CMake seems unable to handle rc versions (what?). Anyway, I'll find another way to do testing without this. |
|
@acmorrow did some digging and it seems like all the components must be nonnegative integers, see https://cmake.org/cmake/help/latest/command/project.html i wouldn't be opposed to using the |
|
Let's just get #410 merged and call it 0.8.0. Meanwhile, could you possibly also take a quick look at viam-modules/mlmodel-tflite#25, which is the same thing? I can't seem to add you as a reviewer - maybe you aren't part of that org? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.