Skip to content

Update update_protos.yml #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 10, 2025
21 changes: 1 addition & 20 deletions .github/workflows/update_protos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
uses: peter-evans/create-pull-request@v7
with:
commit-message: '[WORKFLOW] Updating protos from ${{ github.event.client_payload.repo_name }}, commit: ${{ github.event.client_payload.sha }}'
branch: 'workflow/update-protos'
branch: 'workflow/update-proto'
delete-branch: true
base: main
title: Automated Protos Update
Expand All @@ -60,25 +60,6 @@ jobs:
reviewers: njooma
token: ${{ secrets.GIT_ACCESS_TOKEN }}

- name: Enable Pull Request Automerge
if: steps.cpr.outputs.pull-request-operation == 'created'
uses: peter-evans/enable-pull-request-automerge@v3
with:
token: ${{ secrets.GIT_ACCESS_TOKEN }}
pull-request-number: ${{ steps.cpr.outputs.pull-request-number }}
merge-method: squash

- name: Auto approve
if: steps.cpr.outputs.pull-request-operation == 'created'
run: gh pr review --approve "${{ steps.cpr.outputs.pull-request-number }}"
env:
# (TODO ethan) hard to test for sure but it's possible this is insufficient. it's unclear
# to me whether an approval from `viambot` is sufficient to satisfy merge requirements.
# if not, then this won't work. but that's not particularly bad! it just means we'll still
# have to merge by hand, but then we can add `viambot` as a code owner and then automatic
# merging will start to work.
GH_TOKEN: ${{ secrets.GIT_ACCESS_TOKEN }}

- name: Notify slack of failure
uses: slackapi/[email protected]
if: ${{ failure() }}
Expand Down