Skip to content

Update website development instructions #9577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisgervang
Copy link
Collaborator

Installed on a new computer and discovered since yarn bootstrap no longer builds, the website doesn't work until after running yarn build. Adding this to the docs for new contributors.

@coveralls
Copy link

Coverage Status

coverage: 91.552%. remained the same
when pulling 08a3621 on chr/run-website
into e4891a2 on master.

@@ -10,7 +10,7 @@ PRs and bug reports are welcome, and we are actively looking for new maintainers
The **master** branch is the active development branch.

Building deck.gl locally from the source requires node.js `>=14`. Further limitations on the Node version may be imposed by [puppeteer](https://github.com/puppeteer/puppeteer#usage) and [headless-gl](https://github.com/stackgl/headless-gl#supported-platforms-and-nodejs-versions).
We use [yarn](https://yarnpkg.com/en/docs/install) to manage the dependencies of deck.gl.
We use [yarn](https://yarnpkg.com/en/docs/install) to manage the dependencies of deck.gl, and [volta](https://docs.volta.sh/guide/getting-started) to manage the Node and yarn version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using Volta since we added it in deck.gl. At the same time other projects I work on use corepack and it has painful and frustrating experience (see #9523). I'm going to switch to using corepack exclusively now, and I wonder if it would be better to recommend that here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you manage your node version then? I thought core pack was only for yarn

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, I'm using node 22.8 and it is just working. I really wanted volta to work, but it just didn't play nice with corepack :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants