Skip to content

[Bugfix] Fix and reorganize broken GGUF tests and bump gguf version #16194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Apr 7, 2025

FIX #16180
FIX #16134

  • The GGUF support is broken with numpy 2.0 installation, because we hardcode at a very old gguf version, this PR bump the gguf version to keep compatability with numpy 2.0.
  • This PR also reorganizes the GGUF tests to keep Llama gguf test running on standard test.
  • Also fix the GGUF TP test stucking issue by disabling TP on unquantized runner temporarily.

Copy link

github-actions bot commented Apr 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py requested a review from mgoin April 7, 2025 16:10
@mergify mergify bot added the ci/build label Apr 7, 2025
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 8, 2025
@jeejeelee jeejeelee merged commit f6b32ef into vllm-project:main Apr 8, 2025
85 checks passed
@Isotr0py Isotr0py deleted the gguf-ci branch April 8, 2025 05:40
nishith-fujitsu pushed a commit to nishith-fujitsu/vllm that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
3 participants