Skip to content

[Bugfix] Fix Hermes tool call parser with streaming #18220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johngerving
Copy link

@johngerving johngerving commented May 15, 2025

Fixes an issue where the first argument returned from a function call is not parsed properly by hermes_tool_parser.py when the type of the argument is not a string. This caused the delta of an integer argument to be cut off in the final delta returned to the client, eventually causing the entire first argument of the tool call to be missing.

FIX #18108

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@johngerving johngerving changed the title Fix Hermes tool call parser with streaming [Bugfix] Fix Hermes tool call parser with streaming May 15, 2025
@simon-mo simon-mo requested a review from aarnphm May 23, 2025 01:57
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test case for this? Thanks

@longregen
Copy link

I stumbled into this as well.

Can you write a test case for this? Thanks

I'd be happy to collaborate with this. Are there examples of other similar tests that I can use as a guide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Usage]: Deploy Qwen3-32B in vLLM 0.8.5. In the function_call mode, the results of streaming calls and non-streaming calls are inconsistent.
3 participants