issue8827: When initializing or creating an Azure repository, adjust the log output to JSON format #8864
Conversation
Signed-off-by: Xun Jiang <[email protected]> Signed-off-by: hu-keyu <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]> Signed-off-by: hu-keyu <[email protected]>
…put to JSON format Signed-off-by: hu-keyu <[email protected]>
…put to JSON format Signed-off-by: hu-keyu <[email protected]>
Signed-off-by: hu-keyu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8864 +/- ##
=======================================
Coverage 59.56% 59.56%
=======================================
Files 370 371 +1
Lines 40246 40248 +2
=======================================
+ Hits 23973 23975 +2
Misses 14773 14773
Partials 1500 1500 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…put to JSON format Signed-off-by: hu-keyu <[email protected]>
…put to JSON format Signed-off-by: hu-keyu <[email protected]>
Signed-off-by: hu-keyu <[email protected]>
Already rebased, please review again |
| @@ -56,7 +55,7 @@ func (s *Storage) ConnectionInfo() blob.ConnectionInfo { | |||
| func NewStorage(ctx context.Context, option *Option, isCreate bool) (blob.Storage, error) { | |||
| cfg := option.Config | |||
|
|
|||
| client, _, err := azureutil.NewStorageClient(logrus.New(), cfg) | |||
| client, _, err := azureutil.NewStorageClient(newLogger(), cfg) | |||
There was a problem hiding this comment.
Try to reuse the existing functions in util/logging, e.g., this newLogger function looks very close to the existing DefaultLogger
|
@hu-keyu I meant following two commits.. are they modified from main? why? E2E support sets the --item-block-worker-count. (https://github.com/vmware-tanzu/velero/pull/8836[)](https://github.com/vmware-tanzu/velero/pull/8864/commits/5a5b80c39e06c1e87cedbe9b2d0e6e0235d63168) |
This PR did not modify them. It may be that there is a problem with the local branch synchronizing the remote branch, but the remote branch has been rebased and is not included now. |
|
It's still visible in main...hu-keyu:velero:fix/8827. If we squash when we merge it won't matter. |
…put to JSON format
Thank you for contributing to Velero!
Please add a summary of your change
When initializing or creating an Azure repository, adjust the log output to JSON format.
Does your change fix a particular issue?
Fixes #8827
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.