Skip to content

EDU-14919-new-affiliate-endpoints #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025

Conversation

karenkrieger
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@karenkrieger karenkrieger added the documentation Improvements or additions to documentation label Apr 29, 2025
@karenkrieger karenkrieger self-assigned this Apr 29, 2025
@karenkrieger karenkrieger force-pushed the EDU-14919-new-affiliate-endpoints branch from f7f48e2 to 793c39f Compare April 29, 2025 20:41
Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

GusGuerra
GusGuerra previously approved these changes Apr 29, 2025
anabaarbosa
anabaarbosa previously approved these changes Apr 30, 2025
Copy link
Contributor

@anabaarbosa anabaarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really recommend using components.schemas only in case of repeating schemas, otherwise, it makes maintenance harder.

@PedroAntunesCosta
Copy link
Contributor

I just noticed that this article contains more detailed and helpful information about these fields. I recommend reviewing this content to improve the affiliate endpoints' fields' descriptions. Specially the fields related to the Search endpoint URI.

@karenkrieger karenkrieger force-pushed the EDU-14919-new-affiliate-endpoints branch from ec4d564 to a2f8ee9 Compare May 5, 2025 16:55
@karenkrieger karenkrieger dismissed stale reviews from GusGuerra and anabaarbosa via 5cc9bb8 May 6, 2025 14:12
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@karenkrieger karenkrieger merged commit 0192899 into master May 6, 2025
4 checks passed
@karenkrieger karenkrieger deleted the EDU-14919-new-affiliate-endpoints branch May 6, 2025 15:20
@karenkrieger karenkrieger restored the EDU-14919-new-affiliate-endpoints branch May 6, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants