Skip to content

types(runtime-core): ComponentInstance accept ComponentPublicInstance with any props #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Mar 20, 2024

ComponentInstance<ComponentPublicInstanceConstructor<CreateComponentPublicInstance<Props>>>
currently returns { $props: { $props: Props }}

Copy link

github-actions bot commented Mar 20, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@10557

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@10557

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@10557

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@10557

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@10557

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@10557

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@10557

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@10557

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@10557

vue

pnpm add https://pkg.pr.new/vue@10557

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@10557

commit: 91650e4

@edison1105
Copy link
Member

Could you please add a test case for this?

@edison1105 edison1105 added the need test The PR has missing test cases. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test The PR has missing test cases. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants