fix(vapor): update insertion handling #13203
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert e3a33e6 partial code
If the child is a vdom component:
VaporFragment
(n6 is aVaporFragment
)n4
,n7
, andn2
to all calln6.insert
during creation (caused by the following code):Whenever there is a
v-if
+component
, it causes thecomponent.block
to be inserted twice.It seems we should revert to the original approach by calling
_insert
while keeping_setInsertionState
:_setInsertionState(n8) const n2 = _createIf(() => (_ctx.toggle), () => { const n7 = _createComponent(_VaporKeepAlive, null, { "default": () => { const n4 = _createIf(() => (_ctx.show), () => { const n6 = _createComponent(_ctx.Child) return n6 }) return n4 } }) return n7 }) + _insert(n2, n8)
And remove the following code: