feat[lang]: allow flag members in pure functions #4693
+114
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag members like Action.BUY are compile-time constants and should be allowed in pure functions. This change adds validation logic to detect flag member access patterns and permit them in pure contexts. Changes: - Add is_member_access() helper method to FlagT for cleaner type-specific logic - Update semantic analysis to allow flag member access in pure functions - Add comprehensive tests covering flag operations in pure functions
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Remove trailing whitespace from test file - Shorten comment line to fit within 100 character limit
z80dev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4693 +/- ##
==========================================
+ Coverage 92.93% 92.97% +0.04%
==========================================
Files 131 131
Lines 19006 19067 +61
Branches 3300 3319 +19
==========================================
+ Hits 17663 17728 +65
+ Misses 905 902 -3
+ Partials 438 437 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
charles-cooper
added
the
release - tentative
|
looks good, added some more tests, please merge z80dev#2 |
cyberthirst
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Flag members like Action.BUY are compile-time constants and should be allowed in pure functions. This change adds validation logic to detect flag member access and permit them in pure contexts.
How I did it
Changes:
How to verify it
Run test suite, or compile a contract like:
flag Action: BUY SELL CANCEL @pure @external def get_buy_action() -> Action: return Action.BUY @pure @external def get_sell_action() -> Action: return Action.SELL @pure @external def get_cancel_action() -> Action: return Action.CANCELCommit message
feat: allow flag member usage in pure functions
Description for the changelog
Allow Flag member usage in pure functions
Cute Animal Picture